[24.0] Improved error messages for runtime sharing problems. #17794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels fragile but helpful and necessary. Including a big private/sharing slider right in the modal is imo a great idea! Thanks John. edit: or maybe a just button options that say |
jdavcs
reviewed
Mar 19, 2024
client/src/components/History/Content/Dataset/DatasetMiscInfo.vue
Outdated
Show resolved
Hide resolved
jmchilton
force-pushed
the
helpful_job_errors
branch
from
1441044 to
e7f3571
Compare
jmchilton
force-pushed
the
helpful_job_errors
branch
from
e7f3571 to
6cd4f68
Compare
martenson
reviewed
Mar 21, 2024
Comment on lines
+11
to
+12
| // old sharable error: Attempted to create shared output datasets in objectstore with sharing disabled | ||
| // new sharable error: Job attempted to create sharable output datasets in a storage location with sharing disabled |
There was a problem hiding this comment.
Suggested change
| // old sharable error: Attempted to create shared output datasets in objectstore with sharing disabled | |
| // new sharable error: Job attempted to create sharable output datasets in a storage location with sharing disabled |
There was a problem hiding this comment.
I thought this was for regex debugging, but did you actually want to include it here for posterity?
There was a problem hiding this comment.
yeah - I thought it would be good for future austerity so we can keep ensuring this older message is caught and handled appropriately.
martenson
approved these changes
Mar 21, 2024
|
Thanks, @jmchilton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the error message in the misc_info to reflect #17763. Kind argues the point that "user facing" language is impossible but lets do our best. Adds a little regex framework for scanning the misc_info and providing help if there are problems. I added regex for the old error message also so pre-24.0 dataset errors should get the same improved error message.
If we merge this - I can improve the modal to provide access to these activities inside the of the help text and links and such. But I want to see if we're okay with this a basis framework for handling such errors going forward.
There is also a bunch of things we can probably do pre-job execution to guess if there will be an error and prevent it before it happens. I'll research that but I want to have an abstraction the admin can configure to eliminate the "preferred" language by indicating the admin will always use the configured object store (dynamic destinations don't overwrite the object store id in unpredictable ways).
How to test the changes?
(Select all options that apply)
License